This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Feat: Add UI/Integration tests for creating group, group list and group details #112
Open
jawidMuhammadi
wants to merge
4
commits into
apache:development
Choose a base branch
from
jawidMuhammadi:ui_test
base: development
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge base development branch to my development branch
jawidMuhammadi
force-pushed
the
ui_test
branch
from
August 30, 2020 09:25
e6a885a
to
bcab0de
Compare
miPlodder
suggested changes
Sep 2, 2020
...Test/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt
Show resolved
Hide resolved
...Test/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt
Outdated
Show resolved
Hide resolved
...roidTest/java/org/apache/fineract/ui/online/groups/grouplist/GroupListFragmentAndroidTest.kt
Outdated
Show resolved
Hide resolved
@jawidMuhammadi Add GIF for every PR which you are raising, let's follow the protocol. You can refer to PR for integration tests. |
I was using an emulator, it is difficult to record screens for testing, but if it is necessary then I will add GIF in here too. |
jawidMuhammadi
force-pushed
the
ui_test
branch
2 times, most recently
from
September 2, 2020 08:43
4925474
to
9cd0728
Compare
miPlodder
suggested changes
Sep 2, 2020
...Test/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt
Show resolved
Hide resolved
...Test/java/org/apache/fineract/ui/online/groups/creategroup/CreateGroupActivityAndroidTest.kt
Outdated
Show resolved
Hide resolved
...roidTest/java/org/apache/fineract/ui/online/groups/grouplist/GroupListFragmentAndroidTest.kt
Outdated
Show resolved
Hide resolved
...roidTest/java/org/apache/fineract/ui/online/groups/grouplist/GroupListFragmentAndroidTest.kt
Show resolved
Hide resolved
jawidMuhammadi
force-pushed
the
ui_test
branch
from
September 2, 2020 16:32
f22d816
to
6a4de53
Compare
Can you check this link and add |
3 tasks
@therajanmaurya please review and merge the code, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Issue_number
Please Add Screenshots If any UI changes.
1. Test creating a group item successfully
2. Test creating a group item with invalid office name
3. Test group list item
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.