Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Feat: Add UI/Integration tests for creating group, group list and group details #112

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

jawidMuhammadi
Copy link
Contributor

@jawidMuhammadi jawidMuhammadi commented Aug 30, 2020

Fixes #Issue_number

Please Add Screenshots If any UI changes.

1. Test creating a group item successfully

  • Fill group details
  • Add a member
  • Add a leader
  • Add address details
  • Open review screen
  • Click on the complete button
  • Assert that snack bar message has been displayed

createGroupSuccessfully

2. Test creating a group item with invalid office name

  • Fill group details
  • Enter office name with less than 5 character
  • Click on NEXT button
  • Assert that it doesn't allow navigating to add member fragment

invalidOfficeName

3. Test group list item

  • Open navigation drawer
  • Navigate to Group fragment
  • Click on Group item with "group001" identifier
  • Assert that group item details have been displayed correctly on GroupDetails screen

groupListItem

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything.

  • If you have multiple commits please combine them into one commit by squashing them.

merge base development branch to my development branch
@miPlodder
Copy link
Contributor

miPlodder commented Sep 2, 2020

@jawidMuhammadi Add GIF for every PR which you are raising, let's follow the protocol. You can refer to PR for integration tests.

@jawidMuhammadi
Copy link
Contributor Author

@jawidMuhammadi Add GIF for every PR which you are raising, let's follow the protocol. You can refer to PR for integration tests.

I was using an emulator, it is difficult to record screens for testing, but if it is necessary then I will add GIF in here too.

@jawidMuhammadi jawidMuhammadi marked this pull request as draft September 2, 2020 14:39
@miPlodder
Copy link
Contributor

miPlodder commented Sep 15, 2020

Can you check this link and add ./gradlew build connectedAndroidTest --stacktrace to ensure that UI tests run on the Travis build also, I see they are skipped now.

@jawidMuhammadi
Copy link
Contributor Author

@therajanmaurya please review and merge the code, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants