Skip to content

Commit

Permalink
Merge pull request #572 from angelboxes/FINERACT-757
Browse files Browse the repository at this point in the history
FINERACT-757: Client list retrieval returns emtpy result when using search parameter
  • Loading branch information
vishwasbabu committed May 28, 2019
2 parents 7bf648a + 82568d9 commit cc05940
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ private String buildSqlStringFromClientCriteria(String schemaSql, final SearchPa
}

if (externalId != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(externalId));
paramList.add(externalId);
extraCriteria += " and c.external_id like ? " ;
}

Expand All @@ -262,17 +262,17 @@ private String buildSqlStringFromClientCriteria(String schemaSql, final SearchPa
}

if (firstname != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(firstname));
paramList.add(firstname);
extraCriteria += " and c.firstname like ? " ;
}

if (lastname != null) {
paramList.add(ApiParameterHelper.sqlEncodeString(lastname));
paramList.add(lastname);
extraCriteria += " and c.lastname like ? ";
}

if (searchParameters.isScopedByOfficeHierarchy()) {
paramList.add(ApiParameterHelper.sqlEncodeString(searchParameters.getHierarchy() + "%"));
paramList.add(searchParameters.getHierarchy() + "%");
extraCriteria += " and o.hierarchy like ? ";
}

Expand Down

1 comment on commit cc05940

@vishwasbabu
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angelboxes : Thanks for the very clear issue description !

Please sign in to comment.