Do not expose getApiClient() in FineractClient (FINERACT-1220) #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because FineractClient is about to not use Swagger's ApiClient anymore.
|
@vidakovic OK for you? This is more minor, so I'll self merge this ASAP if you don't have time (no stress). There will be a follow-up PR which will include this commit, I just raised it separately first for both PRs to be easier to review. |
|
FYI: I see no reason why the build should fail where it did on Travis... I think this might have been just a resource problem and re-building would just succeed |
|
The rebuild failed due to FINERACT-1167 (but I saw it green before that). I'll go ahead and self merge this, so that an upcoming new PR which builds on this is easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because FineractClient is about to not use Swagger's ApiClient anymore.