Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINCN-252 Machine Learning Scorecard for Credit Risk Assessment Phase 4 #1811

Closed
wants to merge 1 commit into from
Closed

FINCN-252 Machine Learning Scorecard for Credit Risk Assessment Phase 4 #1811

wants to merge 1 commit into from

Conversation

xurror
Copy link

@xurror xurror commented Aug 6, 2021

Description

Credit Scorecard Algorithms integrations with fineract backend

https://issues.apache.org/jira/browse/FINCN-252

@awasum
Copy link
Contributor

awasum commented Aug 6, 2021

Thanks very much for this work. Why is the issue on the Fineract CN issue tracker and not on the Fineract 1.x issue tracker? cc @edcable

@xurror xurror force-pushed the credit-scorecard branch 2 times, most recently from f6539b4 to 9b75e10 Compare August 16, 2021 05:41
@xurror
Copy link
Author

xurror commented Aug 16, 2021 •
edited

I think there was the idea of making it a microservice, that's why we have a seperate repository where the module server is hosted so it can be run independently.
Some changes feature here because the first level of integration of the project was focused on it's usability with Fineract 1.x.

Referencing Here the UI level changes(openMF/web-app#1353) and Scorecard Server(https://github.com/apache/fineract-credit-scorecard)

@xurror
Copy link
Author

xurror commented Aug 16, 2021

I've finally added the necessary IT tests for this module.

@xurror xurror force-pushed the credit-scorecard branch 5 times, most recently from 157d98e to 27fd0f2 Compare August 19, 2021 12:46
@xurror xurror marked this pull request as ready for review August 20, 2021 01:32
@xurror xurror force-pushed the credit-scorecard branch 2 times, most recently from 70132c6 to 1bbc9d3 Compare September 1, 2021 01:57
@github-actions
Copy link

github-actions bot commented Oct 2, 2021

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Oct 2, 2021
@ptuomola
Copy link
Contributor

ptuomola commented Oct 9, 2021

Looks interesting! Can you fix the merge conflicts and squash the commits please, and I'll take a look...

@github-actions github-actions bot removed the stale label Oct 10, 2021
@awasum
Copy link
Contributor

awasum commented Oct 15, 2021

@xurror Please fix merge conflicts

@xurror xurror force-pushed the credit-scorecard branch 4 times, most recently from 99d51ec to 22a818b Compare October 16, 2021 08:19
@xurror xurror closed this Oct 18, 2021
@xurror xurror reopened this Oct 18, 2021
@xurror
Copy link
Author

xurror commented Oct 18, 2021 •
edited

The PR is good now. Please review when you can. @ptuomola @awasum

BLasan
BLasan requested changes Nov 13, 2021
View reviewed changes
Copy link
Member

@BLasan BLasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Please consider the review comments

@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Dec 14, 2021
@github-actions github-actions bot closed this Jan 13, 2022
@awasum
Copy link
Contributor

awasum commented Jan 13, 2022

@xurror , please fix review comments if possible, fix conflicts so this can be reviewed.

@awasum awasum reopened this Jan 13, 2022
@github-actions github-actions bot removed the stale label Jan 14, 2022
@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Feb 13, 2022
@xurror xurror force-pushed the credit-scorecard branch 2 times, most recently from 27d5923 to 4f25fd6 Compare March 6, 2022 18:54
@vidakovic
Copy link
Contributor

Closing because it looks abandoned.

@vidakovic vidakovic closed this Mar 31, 2022
@awasum
Copy link
Contributor

awasum commented Mar 31, 2022

Closing because it looks abandoned.

I see a commit was made by author 25 days ago..
Please @xurror please can you find time to make the build pass and the merge conflicts all fixed if any... It takes 30 days for the bug to be ato closed by the bot.

@awasum awasum reopened this Mar 31, 2022
@github-actions github-actions bot removed the stale label Apr 1, 2022
@xurror xurror force-pushed the credit-scorecard branch 3 times, most recently from c22a28e to 583dfdf Compare April 4, 2022 03:41
@xurror
Copy link
Author

xurror commented Apr 4, 2022

I think I've now resolved all conflicts on this PR.

@ikimbra
Copy link

ikimbra commented Apr 16, 2022

I'm interested in this feature as we're working on the credit scoring tool at https://github.com/lalitsanagavarapu/mifos-scorecard. @francisguchie, and @rrpawar96 what's your take on this?

@xurror
FINCN-351 Make the scorecard integration into a plugin
42fff7d 
  - Credit Scorecard module:

     - Credit Scorecard organisational module API
     - Rule Based and ML Scoring Entities
     - Credit Scorecard Validators and JSON assemblers
     - Credit Scorecard Read and Write Services
     - Credit Scorecard Flyway Migration
     - Credit scorecard Loan Product Feature Configurations
     - Credit Scorecard integration in Loan Account Creation
     - FINCN-331 Statistical Credit Scorecard
@xurror
Copy link
Author

xurror commented Apr 17, 2022

Passing the build now.

@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label May 18, 2022
@github-actions github-actions bot closed this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLasan BLasan BLasan requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
6 participants
@xurror @awasum @ptuomola @vidakovic @ikimbra @BLasan