FINERACT-982 - Completely ditch use of Drizzle JDBC Driver after all #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awasum
requested changes
Sep 23, 2021
| @@ -31,9 +31,9 @@ CREATE TABLE `m_template` ( | |||
| DROP TABLE IF EXISTS `m_templatemappers`; | |||
| CREATE TABLE `m_templatemappers` ( | |||
| `id` BIGINT NOT NULL AUTO_INCREMENT, | |||
| `mapperkey` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, | |||
| `mapperkey` varchar(255) COLLATE utf8mb4_general_ci DEFAULT NULL, | |||
There was a problem hiding this comment.
What happens to old deployments when u update and previous migration file? Can we instead update in a newer migration script?
|
Hi Awasum,
I will fix it adding the update script. Also I have noticed an error while
running the integraron test in the Pentaho reports.
Regards
El jue., 23 de septiembre de 2021 3:59 a. m., Awasum Yannick <
***@***.***> escribió:
… ***@***.**** requested changes on this pull request.
------------------------------
In
fineract-provider/src/main/resources/sql/migrations/core_db/V119__add_template_table.sql
<#1882 (comment)>:
> @@ -31,9 +31,9 @@ CREATE TABLE `m_template` (
DROP TABLE IF EXISTS `m_templatemappers`;
CREATE TABLE `m_templatemappers` (
`id` BIGINT NOT NULL AUTO_INCREMENT,
- `mapperkey` varchar(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL,
+ `mapperkey` varchar(255) COLLATE utf8mb4_general_ci DEFAULT NULL,
What happens to old deployments when u update and previous migration file?
Can we instead update in a newer migration script?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1882 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALD2ZAQI4ZYHSZ4PKQUI7JDUDLUADANCNFSM5ESZ5F5Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
@awasum , I have gone through the discussion on FINERACT-982, does the PR cater for the non-tech users? |
|
This will work? (of course with the tables affected) fineract/fineract-provider/src/main/resources/sql/migrations/core_db/Vxxx__alter_m_template_for_utf8mb4_general_ci.sql Also I would like to propose to set this at DB level, like this
The file will contain: fineract-db/server_collation.cnf Any thoughs/suggestions? |
|
I will change the approach, not changing anything on the table collation. I will submit another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes were done for replacing the Drizzle JDBC Driver as per issue reported at FINERACT-982 - Completely ditch use of Drizzle JDBC Driver after all