FINERACT-1532: Create an example for pluggability #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidakovic
force-pushed
the
feature/FINERACT-1532
branch
6 times, most recently
from
7d7890e
to
f4ee45a
Compare
galovics
reviewed
Mar 24, 2022
There was a problem hiding this comment.
Looks really good.
One question though @vidakovic, wouldn't it make sense to extract the NoteReadPlatformService/NoteWritePlatformService interfaces along with the NodeData DTO class into a separate "note" module as well? That could kick things off and we have a very real example.
vidakovic
force-pushed
the
feature/FINERACT-1532
branch
from
f4ee45a
to
0f6551b
Compare
galovics
approved these changes
Mar 24, 2022
vidakovic
force-pushed
the
feature/FINERACT-1532
branch
3 times, most recently
from
6269c85
to
fdb0d3b
Compare
vidakovic
force-pushed
the
feature/FINERACT-1532
branch
10 times, most recently
from
80290a9
to
c9cd595
Compare
vidakovic
force-pushed
the
feature/FINERACT-1532
branch
from
c9cd595
to
a18ff03
Compare
This was referenced Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to demonstrate modularity with a minimum of additional configuration. Documentation started.