Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1575 IPv6 workaround #2284

Closed
wants to merge 1 commit into from
Closed

FINERACT-1575 IPv6 workaround #2284

wants to merge 1 commit into from

Conversation

IOhacker
Copy link
Contributor

Description

A bean has been added as a workaround for supporting IPv6 address, which are used in fully managed serverless environments (like Firebase, AWS Amplify, GCP, Azure, Azure App Service).

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

Copy link
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this bean before but after reading the docs and checking the code, this makes sense also from a security standpoint to get rid of all the forward headers and stop attackers injecting some malicious code there.

@galovics galovics requested a review from vidakovic April 21, 2022 08:05
@vidakovic
Copy link
Contributor

vidakovic commented Apr 24, 2022

Same here, never used it before. But, just to be on the cautious side: can we add an "@ConditionalOnProperty" with a property that is set by default to false? That way those who want to use this can, and those who are unaware are not getting something they didn't order.
Talking of unaware: could we add some documentation to explain what this is for and why people would want it? Just to beef up the documentation (or at least a note that we need to explain later).
Other than that: good.

@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label May 25, 2022
@galovics
Copy link
Contributor

Closing as it's obsolete. Please reopen if you're planning to work on it.

@galovics galovics closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants