New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lombok to GLAccount module #2455
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidakovic
reviewed
Jul 25, 2022
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jul 25, 2022
...act-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jul 25, 2022
...rc/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccountRepositoryWrapper.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jul 25, 2022
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
Show resolved
Hide resolved
vidakovic
reviewed
Jul 25, 2022
...ract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java
Show resolved
Hide resolved
vidakovic
reviewed
Jul 25, 2022
...ract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java
Outdated
Show resolved
Hide resolved
@hmg65 could it be that you don't have the Lombok IntelliJ plugin installed?
…On Tue, Jul 26, 2022 at 11:21 PM Hemant Gupta ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java
<#2455 (comment)>:
> @@ -132,14 +135,6 @@ private GLAccountData(String name, Long parentId, String glCode, Boolean manualE
this.allowedExpensesTagOptions = null;
}
- public Integer getRowIndex() {
- return rowIndex;
- }
-
- public CodeValueData getTagId() {
- return tagId;
- }
-
public GLAccountData(final Long id, final String name, final Long parentId, final String glCode, final boolean disabled,
annotating with @requiredargsconstructor gives an error at lines 194-195.
error : cannot resolve constructor
I guess the constructor is not generated here even after applying
@requiredargsconstructor.
—
Reply to this email directly, view it on GitHub
<#2455 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4ZLY24ZTKJDCYVG3ZVMTVWBJF3ANCNFSM54SCWEVA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@vidakovic Lombok IntelliJ plugin is already installed. |
vidakovic
reviewed
Jul 29, 2022
...ract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jul 29, 2022
...ract-provider/src/main/java/org/apache/fineract/accounting/glaccount/data/GLAccountData.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Jul 29, 2022
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/GLAccount.java
Outdated
Show resolved
Hide resolved
luckyman20
force-pushed
the
glaccount
branch
2 times, most recently
from
July 30, 2022 19:47
c219f05
to
1badd8c
Compare
hmg65
force-pushed
the
glaccount
branch
3 times, most recently
from
July 30, 2022 20:51
b8cb72e
to
3fd196f
Compare
@hmg65 it's weird that these integration tests are failing... did you recently rebase your PR with the latest from upstream develop? Maybe you are missing something... just FYI |
vidakovic
reviewed
Jul 31, 2022
...unting/financialactivityaccount/service/FinancialActivityAccountReadPlatformServiceImpl.java
Show resolved
Hide resolved
@hmg65 long inactivity... any blockers? |
closing this PR due to rebase issues. Opened new PR #2497. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.