Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lombok to GLAccount module #2455

Closed
wants to merge 1 commit into from
Closed

Conversation

hmg65
Copy link
Contributor

@hmg65 hmg65 commented Jul 25, 2022

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@vidakovic
Copy link
Contributor

vidakovic commented Jul 27, 2022 via email

@hmg65
Copy link
Contributor Author

hmg65 commented Jul 27, 2022

@vidakovic Lombok IntelliJ plugin is already installed.

@luckyman20 luckyman20 force-pushed the glaccount branch 2 times, most recently from c219f05 to 1badd8c Compare July 30, 2022 19:47
@hmg65 hmg65 force-pushed the glaccount branch 3 times, most recently from b8cb72e to 3fd196f Compare July 30, 2022 20:51
@vidakovic
Copy link
Contributor

@hmg65 it's weird that these integration tests are failing... did you recently rebase your PR with the latest from upstream develop? Maybe you are missing something... just FYI

@vidakovic vidakovic self-requested a review July 31, 2022 15:51
@vidakovic
Copy link
Contributor

@hmg65 long inactivity... any blockers?

@hmg65
Copy link
Contributor Author

hmg65 commented Aug 9, 2022

closing this PR due to rebase issues. Opened new PR #2497.

@hmg65 hmg65 closed this Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants