[FINERACT-1678] configuration validation for COBs #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taskain7
force-pushed
the
configuration-validation-for-loan-cob
branch
5 times, most recently
from
0793086
to
616514c
Compare
galovics
previously requested changes
Aug 4, 2022
...pache/fineract/infrastructure/core/config/FineractPartitionJobConfigValidationCondition.java
Outdated
Show resolved
Hide resolved
...pache/fineract/infrastructure/core/config/FineractPartitionJobConfigValidationCondition.java
Outdated
Show resolved
Hide resolved
...pache/fineract/infrastructure/core/config/FineractPartitionJobConfigValidationCondition.java
Outdated
Show resolved
Hide resolved
...pache/fineract/infrastructure/core/config/FineractPartitionJobConfigValidationCondition.java
Show resolved
Hide resolved
taskain7
force-pushed
the
configuration-validation-for-loan-cob
branch
2 times, most recently
from
ab4aea6
to
fd647f5
Compare
vidakovic
dismissed
galovics’s stale review
Arnold is on sick leave... Adam approved, will merge.
vidakovic
reviewed
Aug 8, 2022
vidakovic
reviewed
Aug 8, 2022
...rovider/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 8, 2022
...rovider/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 8, 2022
...rovider/src/main/java/org/apache/fineract/infrastructure/core/config/FineractProperties.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 8, 2022
fineract-provider/src/test/resources/application-test.properties
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
configuration-validation-for-loan-cob
branch
2 times, most recently
from
5413666
to
40c7e9e
Compare
taskain7
force-pushed
the
configuration-validation-for-loan-cob
branch
2 times, most recently
from
9b0b67c
to
0f3604a
Compare
taskain7
force-pushed
the
configuration-validation-for-loan-cob
branch
from
0f3604a
to
d5e863a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If any COB has partition size, chunk size or thread count below 1, or the partiotion size is less than chunk size * thread count, then the startup fails on the validation.