[FINERACT-1678] Cob job skeleton #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taskain7
force-pushed
the
cob-job-skeleton
branch
6 times, most recently
from
ec1faa0
to
3fe023d
Compare
taskain7
force-pushed
the
cob-job-skeleton
branch
2 times, most recently
from
408206e
to
f2c879d
Compare
taskain7
force-pushed
the
cob-job-skeleton
branch
4 times, most recently
from
f83acdc
to
6def2cb
Compare
|
@taskain7 Would you check why the jobs are timing out? |
I'm on it |
taskain7
force-pushed
the
cob-job-skeleton
branch
8 times, most recently
from
fb85cb8
to
b465684
Compare
galovics
requested changes
Aug 16, 2022
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobName.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBWorkerConfiguration.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBWorkerConfiguration.java
Outdated
Show resolved
Hide resolved
| List<Integer> remainingData = new ArrayList<>(data); | ||
| return () -> { | ||
| if (remainingData.size() > 0) { | ||
| return loanRepository.findById(remainingData.remove(0).longValue()).orElse(null); |
There was a problem hiding this comment.
This seems to be an overkill to issue a single statement for every single ID, don't you think?
We shall rather grab a chunk size of Loans at once.
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBPartitioner.java
Show resolved
Hide resolved
...ract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBInputChannelTransformer.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBMessage.java
Outdated
Show resolved
Hide resolved
...act-provider/src/main/java/org/apache/fineract/cob/loan/LoanCOBOutputChannelTransformer.java
Outdated
Show resolved
Hide resolved
...-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepository.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/resources/db/changelog/tenant/parts/0037_add_loan_cob_job_data.xml
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
cob-job-skeleton
branch
from
b465684
to
d8da59f
Compare
galovics
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a skeleton for the remote partitioned Loan COB Spring Batch job.