FINERACT-1678: Lock under processing loan accounts #2576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the database structure in place for loan account locks, we need to utilize it.
In this story, we need to create a new Spring Batch step (not business steps) and add it into the Loan COB job. The new step will be locking the loan accounts. Also, at the end of the execution of the business steps, we need to unlock the loan accounts within the chunk (it’s important to do it in the same transaction as the business steps).
Acceptance criteria
A new lock loan accounts Spring Batch step is introduced
The lock loan accounts step locks the loan accounts which are in the chunk meaning that rows need to be inserted into the lock table
A new unlock loan accounts mechanism is introduced
The unlock loan accounts mechanism unlocks the loan accounts which are in the chunk meaning that rows need to be deleted from the lock table
The lock loan accounts step is in the beginning of the execution, before executing the business steps
The unlock loan accounts step is at the end of the business step execution in the same transaction
If there was an error during processing a loan account, the exception shall be written in the corresponding lock row for later analysis
The lock_owner column is filled properly with LOAN_COB_CHUNK_PROCESSING
Note
Skipping for the Spring Batch step shall be enabled
A SkipListener could be useful
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.