[FINERACT-1678] Inline COB API #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taskain7
force-pushed
the
inline-COB-API
branch
4 times, most recently
from
7f66876
to
5ee624b
Compare
galovics
requested changes
Oct 15, 2022
There was a problem hiding this comment.
Overall I'm still confused by the naming in the PR. The inline functionality is not tied to COBs but any partitioned job in the future. Let's get rid of this naming and be more generic.
Plus, I'd love to see at least a single integration test for the inline COB's positive scenario.
fineract-provider/src/main/java/org/apache/fineract/cob/api/InlineCOBResource.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/api/InlineCOBResource.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/api/InlineCOBResource.java
Outdated
Show resolved
Hide resolved
...ovider/src/main/java/org/apache/fineract/cob/loan/InlineCOBBuildExecutionContextTasklet.java
Outdated
Show resolved
Hide resolved
...ovider/src/main/java/org/apache/fineract/cob/loan/InlineCOBBuildExecutionContextTasklet.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineCOBType.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
jdailey
reviewed
Oct 15, 2022
taskain7
force-pushed
the
inline-COB-API
branch
5 times, most recently
from
3a2483c
to
4cd30c6
Compare
galovics
requested changes
Oct 17, 2022
fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineCOBLoanItemProcessor.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/org/apache/fineract/cob/loan/InlineLoanCOBBuildExecutionContextTasklet.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanItemProcessor.java
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanItemProcessor.java
Outdated
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineCOBLoanItemReader.java
Show resolved
Hide resolved
fineract-provider/src/main/java/org/apache/fineract/cob/loan/LoanItemReader.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public CommandProcessingResult processCommand(JsonCommand command) { | ||
| List<String> split = Splitter.on("/").splitToList(command.getUrl()); |
There was a problem hiding this comment.
Still don't agree with this, please fix it.
...act-provider/src/main/java/org/apache/fineract/cob/service/InlineCOBExecutionDataParser.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
inline-COB-API
branch
7 times, most recently
from
7ee1e2f
to
9d08a5f
Compare
taskain7
force-pushed
the
inline-COB-API
branch
from
9d08a5f
to
5b6ebd0
Compare
galovics
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Inline Loan COB job.
A new API has been introduced to execute Inline COBs.