FINERACT-1744 - Idempotency support #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0c1
force-pushed
the
FINERACT-1744-integration
branch
15 times, most recently
from
4a57674
to
57c9673
Compare
galovics
requested changes
Nov 25, 2022
...ract-provider/src/main/java/org/apache/fineract/commands/service/IdempotencyKeyResolver.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
Outdated
Show resolved
Hide resolved
...act-provider/src/main/java/org/apache/fineract/commands/handler/NewCommandSourceHandler.java
Show resolved
Hide resolved
...org/apache/fineract/infrastructure/core/exceptionmapper/DuplicateCommandExceptionMapper.java
Outdated
Show resolved
Hide resolved
...ation-tests/src/test/java/org/apache/fineract/integrationtests/common/IdempotencyHelper.java
Outdated
Show resolved
Hide resolved
b0c1
force-pushed
the
FINERACT-1744-integration
branch
3 times, most recently
from
d75baf4
to
198eb95
Compare
galovics
requested changes
Nov 26, 2022
...va/org/apache/fineract/infrastructure/core/exception/AbstractIdempotentCommandException.java
Outdated
Show resolved
Hide resolved
...org/apache/fineract/infrastructure/core/exceptionmapper/DuplicateCommandExceptionMapper.java
Outdated
Show resolved
Hide resolved
b0c1
force-pushed
the
FINERACT-1744-integration
branch
2 times, most recently
from
4775a37
to
82d0323
Compare
- [x] Idempotency write move to filters - [x] Idempotency integration test with success and failure - [x] Added response status code to database - [x] SynchronousCommandProcessingService not generate the command, just marked to the filter - [x] IdempotencyStoreFilter store the command request if available. - [x] Removed JpaExceptionHandler.java
b0c1
force-pushed
the
FINERACT-1744-integration
branch
from
82d0323
to
46bbda9
Compare
galovics
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-1744 - Idempotency support
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.