FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

[josehernandezfintecheandomx]

Description

Fix on API level which will remove the Edit option of Goodwill Credit, Payout Refund and Merchant Issued Refund transactions

FINERACT-1847

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per https://github.com/apache/fineract/#pull-requests

• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

• Create/update unit or integration tests for verifying the changes made.

• Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

• Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

[adamsaghy]

@josehernandezfintecheandomx Please double check the tests. It is failing with this:

java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsJsonArray()" because the return value of "com.google.gson.JsonObject.get(String)" is null
[2138](https://github.com/apache/fineract/actions/runs/3825276813/jobs/6508131758#step:11:2139)
      at org.apache.fineract.integrationtests.BatchApiTest.shouldReturnOkStatusForBatchGoodwillCreditReversal(BatchApiTest.java:1815)

[josehernandezfintecheandomx]

@josehernandezfintecheandomx Please double check the tests. It is failing with this:

java.lang.NullPointerException: Cannot invoke "com.google.gson.JsonElement.getAsJsonArray()" because the return value of "com.google.gson.JsonObject.get(String)" is null
[2138](https://github.com/apache/fineract/actions/runs/3825276813/jobs/6508131758#step:11:2139)
      at org.apache.fineract.integrationtests.BatchApiTest.shouldReturnOkStatusForBatchGoodwillCreditReversal(BatchApiTest.java:1815)

Done! @adamsaghy I needed to update this test because the reversal or edit for these transactions are not allowed more

[galovics]

@josehernandezfintecheandomx test is still failing

  Test applyLoanTransactionChargeback() FAILED

  java.lang.AssertionError: 1 expectation failed.
  Expected status code <403> but was <503>.
      at org.apache.fineract.integrationtests.LoanTransactionChargebackTest.applyLoanTransactionChargeback(LoanTransactionChargebackTest.java:120)

[adamsaghy]

Please add test cases to cover the adjusting of the goodwill credit, payout refund and merchant issued refund and chargeback is not possible and they throw the proper error.

Also please remove the "dead code" which was added (CommandWrapperBuilder.java)

[adamsaghy]

Missing test cases:
Please add test cases to cover the adjusting of the goodwill credit, payout refund and merchant issued refund and chargeback is not possible and they throw the proper error.

[adamsaghy]

@josehernandezfintecheandomx Testing whether adjusting

• merchant issued refund
• chargeback

is not enabled is still missing. Would you please add the test cases for these two as well?

[adamsaghy]

Please extract the bugfix of "updateClient" logic into a new, separate PR!

[adamsaghy]

LGTM