FINERACT-1707: Transaction Summary Report changes #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamsaghy @alexivanov could any one of you please help in reviewing this PR? |
adamsaghy
reviewed
Feb 17, 2023
| <!-- Transaction Summary report --> | ||
| <changeSet author="fineract" id="3"> | ||
| <update tableName="stretchy_report"> | ||
| <column name="report_sql" value="SELECT |
There was a problem hiding this comment.
is this working with mysql and postgres as well?
|
@josehernandezfintecheandomx Kindly fix the conflict and please help me check whether this report is working with mysql and postgres as well? (should we have a test which calls it and check some outcome maybe?) |
josehernandezfintecheandomx
force-pushed
the
enhancement/update_accounting_report
branch
from
588e508
to
9172dda
Compare
|
@adamsaghy could you please review again and merge please? |
I am still waiting on @josehernandezfintecheandomx reply on my questions... |
|
@adamsaghy the script works both on mysql and postgres. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transaction Summary report updated with the following changes
FINERACT-1707
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.