FINERACT-1724: Fee's are not included in total balance amount, when we have multiple disbursements on first day #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
commented
May 2, 2023
| if (installmentNumber == null && charge.isDueForCollectionFromAndUpToAndIncluding(startDate, installment.getDueDate())) { | ||
|
|
||
| boolean isDue = installment.isFirstPeriod() | ||
| ? charge.isDueForCollectionFromIncludingAndUpToAndIncluding(startDate, installment.getDueDate()) |
mohitsinha
reviewed
May 2, 2023
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
Outdated
Show resolved
Hide resolved
mohitsinha
reviewed
May 2, 2023
...anaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
Show resolved
Hide resolved
mohitsinha
approved these changes
May 2, 2023
There was a problem hiding this comment.
Left comments regarding 2 cases, where we just check if loanCharge is due or not.
The startDate in both these cases is disbursementDate and endDate is installment.getDueDate(), so only installment.dueDate parameter is sufficient.
Can there be 1 IT for this flow?
Thank you for your review! I have replied to your comments and i am working on the IT test case. |
adamsaghy
force-pushed
the
FINERACT-1724/enhance_charge_handling
branch
2 times, most recently
from
f3aadf7
to
aba2cc4
Compare
…e have multiple disbursements on first day
adamsaghy
force-pushed
the
FINERACT-1724/enhance_charge_handling
branch
from
aba2cc4
to
62b2faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.