FINERACT-1912 Support Pagination, sorting and filtering for Savings account transactions #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
galovics
requested changes
May 23, 2023
...r/src/main/java/org/apache/fineract/portfolio/account/domain/AccountTransferTransaction.java
Outdated
Show resolved
Hide resolved
...provider/src/main/java/org/apache/fineract/portfolio/paymentdetail/domain/PaymentDetail.java
Outdated
Show resolved
Hide resolved
...vider/src/main/java/org/apache/fineract/portfolio/savings/SavingsAccountTransactionType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionDTOV2.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionDTOV2.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/fineract/integrationtests/SavingsAccountTransactionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/fineract/integrationtests/SavingsAccountTransactionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/fineract/integrationtests/SavingsAccountTransactionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/fineract/integrationtests/SavingsAccountTransactionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/fineract/integrationtests/SavingsAccountTransactionsIntegrationTest.java
Outdated
Show resolved
Hide resolved
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
2 times, most recently
from
3d4d7ed
to
41e1cf5
Compare
Mk9894
commented
Jun 2, 2023
...src/main/java/org/apache/fineract/portfolio/savings/data/SavingsTransactionSearchResult.java
Outdated
Show resolved
Hide resolved
|
I'm going to read in on this PR to see if I can help out with the lift. |
adamsaghy
reviewed
Jun 5, 2023
| @Operation(summary = "Search Savings Account Transactions") | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "OK", content = @Content(schema = @Schema(implementation = SavingsAccountTransactionsApiResourceSwagger.SavingsAccountTransactionsSearchResponse.class))) }) | ||
| public String searchTransactions(@PathParam("savingsId") @Parameter(description = "savingsId") final Long savingsId, |
There was a problem hiding this comment.
Please use the Spring DATA Page instead of the "own"...
The idea is to move towards the standard solutions and let the "custom" ones got deprecated slowly.
There was a problem hiding this comment.
Hi Adam,
I had also considered utilizing the Spring Data Page instead of the legacy response. However, Peter expressed a preference for the response to resemble the legacy implementation. If it is necessary for me to accommodate the legacy response fields while incorporating the spring data Page, it will require a refactoring of all the transaction-related entities.
I am concerned that making those changes may potentially disrupt the existing implementations.
There was a problem hiding this comment.
@Mk9894 I see.. would you please change than only to be this v1?
The idea is v2 is using the new way of generating the swagger definitions and using the Spring data page and some other enhancements, if this is to support the legacy pagination, it should remain v1.
is that okay?
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
from
41e1cf5
to
ab8888c
Compare
adamsaghy
previously approved these changes
Jun 5, 2023
galovics
requested changes
Jun 6, 2023
.../main/java/org/apache/fineract/portfolio/savings/domain/search/SavingsTransactionSearch.java
Show resolved
Hide resolved
.../main/java/org/apache/fineract/portfolio/savings/domain/search/SavingsTransactionSearch.java
Show resolved
Hide resolved
...apache/fineract/portfolio/savings/domain/search/SavingsTransactionsSearchRepositoryImpl.java
Outdated
Show resolved
Hide resolved
...apache/fineract/portfolio/savings/domain/search/SavingsTransactionsSearchRepositoryImpl.java
Outdated
Show resolved
Hide resolved
...apache/fineract/portfolio/savings/domain/search/SavingsTransactionsSearchRepositoryImpl.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/fineract/integrationtests/common/savings/SavingsAccountHelper.java
Outdated
Show resolved
Hide resolved
...va/org/apache/fineract/integrationtests/SavingsAccountTransactionsSearchIntegrationTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/fineract/integrationtests/SavingsAccountTransactionsSearchIntegrationTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/fineract/integrationtests/SavingsAccountTransactionsSearchIntegrationTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/fineract/integrationtests/SavingsAccountTransactionsSearchIntegrationTest.java
Outdated
Show resolved
Hide resolved
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
from
ab8888c
to
f4f82af
Compare
galovics
approved these changes
Jun 12, 2023
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
from
f4f82af
to
3024e18
Compare
|
Let's figure out a solution to the auto checks failing. Gradle upgrade could be part of this. |
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
from
3024e18
to
f25fc44
Compare
…n Search FINERACT-1912 Refactored Implementation of Savings Account Transaction Search FINERACT-1912 Refactored Implementation of Savings Account Transaction Search FINERACT-1912 Savings Account Transaction Advanced Search Support FINERACT-1912 Savings Account Transaction Advanced Search Support Support Pagination, Sorting and Filtering By transaction Type, Transaction Date and Amount Supported Filtering for Amount and Date, GTE, LTE, GT, LT Supported Multiple Transaction Types Filtering
Mk9894
force-pushed
the
FINERACT-1912-rebase
branch
from
f25fc44
to
73f5f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.