Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1954: Waive null pointer and due date fix #3322

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

b0c1
Copy link
Contributor

@b0c1 b0c1 commented Jul 21, 2023

FINERACT-1954: Waive null pointer and due date fix

  • Fix Waive due date handle
  • Fix null pointer exception
  • Integration test

@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch 3 times, most recently from bb62ab8 to 3c342b6 Compare July 24, 2023 22:28
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments!

@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch from 3c342b6 to 7557c45 Compare July 25, 2023 14:50
@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch from 7557c45 to 8741ca5 Compare July 26, 2023 08:44
@b0c1 b0c1 requested a review from adamsaghy July 26, 2023 08:54
@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch from 8741ca5 to 0221d4c Compare July 26, 2023 12:03
@b0c1 b0c1 requested a review from adamsaghy July 26, 2023 12:04
@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch from 0221d4c to 34832d9 Compare July 26, 2023 13:39
- [x] Fix Waive due date handle
- [x] Fix null pointer exception
- [x] Integration test
@b0c1 b0c1 force-pushed the FINERACT-1954-due-date-and-null-fix branch from 34832d9 to f18aa47 Compare July 26, 2023 14:23
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit ea172db into apache:develop Jul 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants