-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FINERACT-1954: Waive null pointer and due date fix #3322
Merged
adamsaghy
merged 1 commit into
apache:develop
from
b0c1:FINERACT-1954-due-date-and-null-fix
Jul 27, 2023
Merged
FINERACT-1954: Waive null pointer and due date fix #3322
adamsaghy
merged 1 commit into
apache:develop
from
b0c1:FINERACT-1954-due-date-and-null-fix
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
3 times, most recently
from
July 24, 2023 22:28
bb62ab8
to
3c342b6
Compare
adamsaghy
reviewed
Jul 25, 2023
...-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java
Show resolved
Hide resolved
adamsaghy
requested changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments!
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
from
July 25, 2023 14:50
3c342b6
to
7557c45
Compare
adamsaghy
reviewed
Jul 25, 2023
...-tests/src/test/java/org/apache/fineract/integrationtests/LoanChargeSpecificDueDateTest.java
Show resolved
Hide resolved
adamsaghy
reviewed
Jul 25, 2023
...va/org/apache/fineract/portfolio/loanaccount/service/LoanChargeWritePlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
from
July 26, 2023 08:44
7557c45
to
8741ca5
Compare
adamsaghy
reviewed
Jul 26, 2023
...anaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
from
July 26, 2023 12:03
8741ca5
to
0221d4c
Compare
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
from
July 26, 2023 13:39
0221d4c
to
34832d9
Compare
- [x] Fix Waive due date handle - [x] Fix null pointer exception - [x] Integration test
b0c1
force-pushed
the
FINERACT-1954-due-date-and-null-fix
branch
from
July 26, 2023 14:23
34832d9
to
f18aa47
Compare
adamsaghy
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FINERACT-1954: Waive null pointer and due date fix