FINERACT-1932: Add configuration for useradministration service #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
from
fd246c8
to
c9ee7b8
Compare
vidakovic
reviewed
Aug 17, 2023
...main/java/org/apache/fineract/useradministration/service/AppUserReadPlatformServiceImpl.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...act/useradministration/service/PasswordPreferencesWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...n/java/org/apache/fineract/useradministration/service/PermissionReadPlatformServiceImpl.java
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...che/fineract/useradministration/service/PermissionWritePlatformServiceJpaRepositoryImpl.java
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...rc/main/java/org/apache/fineract/useradministration/service/RoleReadPlatformServiceImpl.java
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...java/org/apache/fineract/useradministration/starter/UserAdministrationAutoConfiguration.java
Outdated
Show resolved
Hide resolved
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
2 times, most recently
from
8df4314
to
9ffa2c9
Compare
vidakovic
reviewed
Aug 17, 2023
| @@ -6,9 +6,9 @@ | |||
| * to you under the Apache License, Version 2.0 (the | |||
| * "License"); you may not use this file except in compliance | |||
| * with the License. You may obtain a copy of the License at | |||
| * | |||
| * <p> | |||
There was a problem hiding this comment.
This will probably fail. Before you submit please run ./gradlew spotlessApply to fix (most) of these (formatting) errors.
There was a problem hiding this comment.
Done. I'll make sure to review git differecnes before opening future PRs to avoid this.
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
2 times, most recently
from
f7088f6
to
d414b3d
Compare
vidakovic
changed the title
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
from
d414b3d
to
7d3a3e0
Compare
adamsaghy
reviewed
Aug 22, 2023
| import org.springframework.jdbc.core.JdbcTemplate; | ||
|
|
||
| @Configuration | ||
| public class UserAdministrationAutoConfiguration { |
There was a problem hiding this comment.
This is not auto configuration. Please rename it.
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
from
7d3a3e0
to
f18a27c
Compare
abhinav7sinha
changed the title
abhinav7sinha
force-pushed
the
FINERACT-1932/useradministration-module
branch
from
f18a27c
to
a7668fa
Compare
galovics
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…NERACT-1932)
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.