Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-1932: Add custom Configuration class for tax service #3374

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

mmagdiab
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@mmagdiab mmagdiab changed the title Add custom AutoConfiguration class for tax service (FINERACT-1932) FINERACT-1932: Add custom AutoConfiguration class for tax service Aug 18, 2023
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmagdiab mmagdiab force-pushed the FINERACT-1932/tax-module branch 2 times, most recently from acbd012 to 7f7d974 Compare August 22, 2023 03:30
@mmagdiab mmagdiab force-pushed the FINERACT-1932/tax-module branch 2 times, most recently from ee823bc to 2c7aa5b Compare September 3, 2023 14:50
@galovics galovics changed the title FINERACT-1932: Add custom AutoConfiguration class for tax service FINERACT-1932: Add custom Configuration class for tax service Sep 4, 2023
@adamsaghy
Copy link
Contributor

@mmagdiab Please kindly check the below error:

    (see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
  Did you mean 'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.ROOT)) + " account with identifier " + id + " does not exist", id, e);' or 'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.getDefault())) + " account with identifier " + id + " does not exist", id, e);' or 'StringUtils.capitalize(Ascii.toLowerCase(accountType.toString())) + " account with identifier " + id + " does not exist", id, e);'?
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/starter/TaxConfiguration.java:29: error: [WildcardImport] Wildcard imports, static or otherwise, should not be used
import org.apache.fineract.portfolio.tax.service.*;

@mmagdiab
Copy link
Contributor Author

@mmagdiab Please kindly check the below error:

    (see https://errorprone.info/bugpattern/StringCaseLocaleUsage)
  Did you mean 'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.ROOT)) + " account with identifier " + id + " does not exist", id, e);' or 'StringUtils.capitalize(accountType.toString().toLowerCase(Locale.getDefault())) + " account with identifier " + id + " does not exist", id, e);' or 'StringUtils.capitalize(Ascii.toLowerCase(accountType.toString())) + " account with identifier " + id + " does not exist", id, e);'?
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/tax/starter/TaxConfiguration.java:29: error: [WildcardImport] Wildcard imports, static or otherwise, should not be used
import org.apache.fineract.portfolio.tax.service.*;

resolved

@galovics galovics merged commit 34fc1a2 into apache:develop Oct 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants