FINERACT-1958-Rework-Down-Payment-Overlapping-Installment #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
requested changes
Sep 22, 2023
...apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java
Outdated
Show resolved
Hide resolved
ruchiD
force-pushed
the
FINERACT-1958-Rework-Down-Payment-Overlapping-Installment
branch
from
bab8840
to
d8ae02c
Compare
reluxa
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
It is looking good to me.
minor comment1: in the tests I would have added assertions for the disbursements as well. It's a bit weird that we have gaps in the indexes
loanDetails.getRepaymentSchedule().getPeriods().get(....).getPeriod()
Minor comment 2: I think a helper method which asserts all the attributes of an installments in the testcase could improve the readability.
reluxa
reviewed
Sep 26, 2023
| assertEquals(0.0, loanDetails.getRepaymentSchedule().getPeriods().get(4).getPenaltyChargesPaid()); | ||
| assertEquals(true, loanDetails.getRepaymentSchedule().getPeriods().get(4).getComplete()); | ||
|
|
||
| // third period [2023-04-03 to 2023-04-03] overlapping down payment installment |
There was a problem hiding this comment.
Just for double checking. We don't want to create two separate entries for the two downpayments happend on the same day, right?
ruchiD
force-pushed
the
FINERACT-1958-Rework-Down-Payment-Overlapping-Installment
branch
from
d8ae02c
to
b6d8389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for overlapping installments for down payments.
Test fix.
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.