Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FINERACT-1971: Swagger classes primary keys fix #3545

Merged
merged 7 commits into from
Oct 31, 2023
Merged

FINERACT-1971: Swagger classes primary keys fix #3545

merged 7 commits into from
Oct 31, 2023

Conversation

peter-kovacs-dpc
Copy link
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@reluxa
Copy link
Contributor

reluxa commented Oct 27, 2023

Long awaited, thanks:

Alt Text

reluxa
reluxa approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@reluxa reluxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamsaghy
adamsaghy requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please kindly review my comments!

It's great you are contributing these fixes! ;)

@vidakovic vidakovic changed the title FINERACT-1971 swagger classes primary keys fix FINERACT-1971: Swagger classes primary keys fix Oct 30, 2023
adamsaghy
adamsaghy approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adamsaghy
adamsaghy approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics galovics merged commit 5ebeca0 into apache:develop Oct 31, 2023
8 checks passed
josehernandezfintecheandomx pushed a commit to openMF/fineract-advancly that referenced this pull request Nov 24, 2023
@peter-kovacs-dpc @galovics
FINERACT-1971: Swagger classes primary keys fix (apache#3545)
b0e7868 
FINERACT-1971 Swagger adjustments

---------

Co-authored-by: Arnold Galovics <galovicsarnold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galovics galovics galovics left review comments

@reluxa reluxa reluxa approved these changes

@adamsaghy adamsaghy adamsaghy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@peter-kovacs-dpc @reluxa @galovics @adamsaghy