Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2006: Forgot password on login page #3559

Closed
wants to merge 1 commit into from

Conversation

tabrez-fiter
Copy link

@tabrez-fiter tabrez-fiter commented Nov 1, 2023

Description

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@vidakovic
Copy link
Contributor

@tabrez-fiter ... don't want to appear too picky... but uppercase "FINERACT" (not capitalized as you did) and no additional space before the colon.... just look at the other PRs. Thanks for paying attention to these details (there are some tools setup in Jira that depend on being accurate here). I've corrected the title.

@vidakovic vidakovic changed the title Fineract-2006 : Forgot password on login page FINERACT-2006: Forgot password on login page Nov 1, 2023
@tabrez-fiter tabrez-fiter changed the title FINERACT-2006: Forgot password on login page Fineract-2006: Forgot password on login page Nov 1, 2023
@tabrez-fiter tabrez-fiter changed the title Fineract-2006: Forgot password on login page FINERACT-2006: Forgot password on login page Nov 1, 2023
@vidakovic vidakovic marked this pull request as draft November 7, 2023 07:01
@vidakovic
Copy link
Contributor

@tabrez-fiter please fix the license header issue. One more request: please hold this one back until we have created release 1.9.0; I am not 100% sure about the backward compatibility of this. Let's merge this after and release for 1.10.0 (marked Jira ticket accordingly).

@vidakovic
Copy link
Contributor

@tabrez-fiter ... please squash the 2 commits into one.

Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Dec 21, 2023
@tabrez-fiter tabrez-fiter marked this pull request as ready for review December 21, 2023 11:37
@github-actions github-actions bot removed the stale label Dec 22, 2023
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Feb 19, 2024
@github-actions github-actions bot closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants