FINERACT-2006: Forgot password on login page #3559
Conversation
|
@tabrez-fiter ... don't want to appear too picky... but uppercase "FINERACT" (not capitalized as you did) and no additional space before the colon.... just look at the other PRs. Thanks for paying attention to these details (there are some tools setup in Jira that depend on being accurate here). I've corrected the title. |
vidakovic
changed the title
tabrez-fiter
changed the title
tabrez-fiter
changed the title
|
@tabrez-fiter please fix the license header issue. One more request: please hold this one back until we have created release 1.9.0; I am not 100% sure about the backward compatibility of this. Let's merge this after and release for 1.10.0 (marked Jira ticket accordingly). |
|
@tabrez-fiter ... please squash the 2 commits into one. |
tabrez-fiter
force-pushed
the
FINERACT-2006
branch
from
2c764bc
to
7e53fd8
Compare
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
tabrez-fiter
force-pushed
the
FINERACT-2006
branch
from
7e53fd8
to
07b293f
Compare
tabrez-fiter
force-pushed
the
FINERACT-2006
branch
from
81c6e97
to
ecefbd3
Compare
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Description
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.