FINERACT-1909: Retry feature for commands - deadlock #3589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marta-jankovics
force-pushed
the
FINERACT-1909
branch
2 times, most recently
from
37045a2
to
f56a92a
Compare
adamsaghy
reviewed
Nov 20, 2023
| commandSource = sameTransaction ? commandSourceService.saveInitialSameTransaction(wrapper, command, user, idempotencyKey) | ||
| : commandSourceService.saveInitialNewTransaction(wrapper, command, user, idempotencyKey); | ||
| storeCommandIdInContext(commandSource); // Store command id as a request attribute | ||
| commandSource = commandSourceService.getInitialCommandSource(wrapper, command, user, idempotencyKey); |
There was a problem hiding this comment.
This looks not correct. If we are not storing in the DB a command processing was started, there is absolutely no defense to start processing the same command multiple times. Am I missing something?
There was a problem hiding this comment.
action_name, entity_name, idempotency_key is a compound unique key, cannot be saved twice. That is true that the idempotency_key is not unique, as I thought, it is.
marta-jankovics
force-pushed
the
FINERACT-1909
branch
3 times, most recently
from
9b59e41
to
f243e0c
Compare
6 tasks
marta-jankovics
force-pushed
the
FINERACT-1909
branch
from
f243e0c
to
fa880ad
Compare
marta-jankovics
force-pushed
the
FINERACT-1909
branch
from
fa880ad
to
5de0765
Compare
adamsaghy
reviewed
Nov 20, 2023
| log.info("\nFinished all threads"); | ||
| } | ||
|
|
||
| // @Test |
There was a problem hiding this comment.
ACK: this test is commented out temporarily till it got fixed (locally and on GA behaves differently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.