FINERACT-1971: Fix when waived N+1 installment's obligationsMet and obligationsMetOnDate is not or wrongly set #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Nov 28, 2023
...anaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Nov 28, 2023
...anaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java
Outdated
Show resolved
Hide resolved
galovics
force-pushed
the
FINERACT-1971-11
branch
3 times, most recently
from
cd60bf3
to
e4039fe
Compare
galovics
force-pushed
the
FINERACT-1971-11
branch
from
e4039fe
to
9a5b8cb
Compare
reluxa
reviewed
Nov 28, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanWaiveChargeTest.java
Show resolved
Hide resolved
galovics
force-pushed
the
FINERACT-1971-11
branch
from
9a5b8cb
to
c15c6c2
Compare
…bligationsMetOnDate is not or wrongly set
galovics
force-pushed
the
FINERACT-1971-11
branch
from
c15c6c2
to
c4da8dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.