FINERACT-2035: Fixed-Client Trend For Day Scale is not work Due to BadSqlGrammar Error #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: FINERACT-2035 Client Trend For Day Scale is not work Due to BadSqlGrammar Error This error is happened due to bucket 1 Day is inside single quotation in 0087_update_dashboard_table_reports.xml file which is responsible for storing SQL query in DB that SQL query is responsible for the BadSQLGrammar Error
|
Please use the same formatting in the commit message as it was used in the PR title. "FINERACT-XXXX: description of the changes". You might wanna use the same as the PR title. |
adamsaghy
reviewed
Dec 31, 2023
| @@ -75,7 +75,7 @@ | |||
| FROM m_office o LEFT JOIN m_client cl on o.id = cl.office_id | |||
| LEFT JOIN m_loan ln on cl.id = ln.client_id | |||
| WHERE o.hierarchy like concat((select ino.hierarchy from m_office ino where ino.id = ${officeId}),'%' ) | |||
| AND (ln.disbursedon_date BETWEEN DATE_SUB(CURDATE(), INTERVAL 12 DAY) AND DATE(NOW()- INTERVAL '1 DAY')) | |||
| AND (ln.disbursedon_date BETWEEN DATE_SUB(CURDATE(), INTERVAL 12 DAY) AND DATE(NOW()- INTERVAL 1 DAY)) | |||
There was a problem hiding this comment.
The same issue might appear in other reports as well. Can you please cover them in this PR?
Also please make sure you have an integration test which cover the issue was truly fixed
There was a problem hiding this comment.
Ok sure, I'll review related reports to identify any instances of the same issue and incorporate the necessary fixes into the PR.
adamsaghy
requested changes
Dec 31, 2023
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: FINERACT-2035
Client Trend For Day Scale is not work Due to BadSqlGrammar Error
This error is happened due to bucket 1 Day is inside single quotation in 0087_update_dashboard_table_reports.xml file which is responsible for storing SQL query in DB that SQL query is responsible for the BadSQLGrammar Error
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.