Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINERACT-2035: Client Trend For Day Scale is not work Due to BadSqlGrammar Error #3727

Closed
wants to merge 3 commits into from
Closed

Conversation

Mariappan-Sivakumar-ZS0528
Copy link
Contributor

Issue: FINERACT-2035
Client Trend For Day Scale is not work Due to BadSqlGrammar Error

This error is happened due to bucket 1 Day is inside single quotation in 0087_update_dashboard_table_reports.xml file which is responsible for storing SQL query in DB that SQL query is responsible for the BadSQLGrammar Error. I check the other queries related to this query but, all of them are working fine

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@Mariappan-Sivakumar-ZS0528 Mariappan-Sivakumar-ZS0528 marked this pull request as draft February 9, 2024 03:37
@Mariappan-Sivakumar-ZS0528
Copy link
Contributor Author

I have solved 2 issues and unfortunately pulled in the same PR. I will dissect and pull in different PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant