FINERACT-2073: Client search v2 using Client Identifiers #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsaghy
reviewed
Mar 26, 2024
fineract-core/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java
Show resolved
Hide resolved
adamsaghy
requested changes
Mar 26, 2024
alberto-art3ch
changed the title
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
9621635
to
55baa97
Compare
Done |
|
Please update the Commit message too! |
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
55baa97
to
81d2bdb
Compare
|
Please update the Commit message too! |
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
81d2bdb
to
1318643
Compare
Done! Commit message updated |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
1318643
to
95195b0
Compare
adamsaghy
requested changes
May 17, 2024
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
95195b0
to
085161d
Compare
alberto-art3ch
force-pushed
the
enhancement/search_client_v2_using_identifiers
branch
from
085161d
to
aba0ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Client search v2 using Client Identifiers in the search values as we have in the general search endpoint. There is not impact or change needed in the UI
FINERACT-2073
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.