FINERACT-1971: RepaymentOverDueBusinessEvent should not be sent when … #3856
Conversation
| @@ -933,6 +936,35 @@ public void saleExceptionHandling() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void buybackOnATobeDeclinedPendingSale() { | |||
There was a problem hiding this comment.
Please remove this test case as it is part of an another PR.
There was a problem hiding this comment.
Done! Test case removed from this class
...ovider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java
Show resolved
Hide resolved
| @@ -175,4 +184,27 @@ public void givenLoanWithInstallmentOverdueAfterConfiguredDaysInLoanProductWhenS | |||
| assertEquals(repaymentInstallment, loanPayloadForEvent); | |||
| assertEquals(processedLoan, loanForProcessing); | |||
| } | |||
|
|
|||
| @Test | |||
| public void givenNonDisbursedLoanWhenStepExecutionThenNoBusinessEventIsRaised() { | |||
There was a problem hiding this comment.
I am not fully understand this test case, but please be sure to cover the following:
GIVEN Loan is SUBMITTED or APPROVED and outstanding amount is greater than ZERO and one of the instalment is OVERDUE
WHEN job got executed
THEN no overdue event
GIVEN Loan is ACTIVE, outstanding amount is ZERO, one of the installment is due date is matching with the actual date
WHEN job got executed
THEN no overdue event triggered
There was a problem hiding this comment.
Done! Test cases created:
givenActiveLoanWithZeroOutstandingWhenStepExecutionThenNoBusinessEventIsRaised
givenActiveLoanWithNonZeroOutstandingWhenStepExecutionThenBusinessEventIsRaised
alberto-art3ch
force-pushed
the
fix/loan_repayment_overdue_event_non_zero_outstanding
branch
from
8a49bd5
to
fdd362e
Compare
| } | ||
|
|
||
| @Test | ||
| public void givenActiveLoanWithNonZeroOutstandingWhenStepExecutionThenBusinessEventIsRaised() { |
There was a problem hiding this comment.
I dont see test case to check whether the event got not raised if the loan status is SUBMITTED or APPROVED
There was a problem hiding this comment.
Done! Unit Test created:
givenSubmittedLoanWhenStepExecutionThenNoBusinessEventIsRaised
givenApprovedLoanWhenStepExecutionThenNoBusinessEventIsRaised
alberto-art3ch
force-pushed
the
fix/loan_repayment_overdue_event_non_zero_outstanding
branch
from
fdd362e
to
fe1c916
Compare
| private static boolean isOverDueEventNeededToBeSent(Loan loan, Long numberOfDaysBeforeDueDateToRaiseEvent, LocalDate currentDate, | ||
| LoanRepaymentScheduleInstallment repaymentScheduleInstallment, LocalDate repaymentDate) { | ||
| return repaymentDate.plusDays(numberOfDaysBeforeDueDateToRaiseEvent).equals(currentDate) | ||
| && loan.getLoanSummary().getTotalOutstanding().compareTo(BigDecimal.ZERO) > 0 |
There was a problem hiding this comment.
Would you mind to move the loan.getLoanSummary().getTotalOutstanding().compareTo(BigDecimal.ZERO) > 0 check to the top, next to the loan status check?
alberto-art3ch
force-pushed
the
fix/loan_repayment_overdue_event_non_zero_outstanding
branch
from
fe1c916
to
dfe5483
Compare
alberto-art3ch
force-pushed
the
fix/loan_repayment_overdue_event_non_zero_outstanding
branch
from
dfe5483
to
b68840a
Compare
…balance is 0
Description
Approved (orphaned) accounts with no disbursement are triggering
RepaymentOverdueDueBusinessEventreminder event after their maturity date.FINERACT-1971
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.