sms notification #410
sms notification #410
Conversation
| } | ||
| } catch (Exception e) { | ||
| throw new ConnectionFailureException(hostName); |
There was a problem hiding this comment.
Swallowing exception. Please check if it's intentional.
There was a problem hiding this comment.
We removed this exception , when sms will be send at that time it will throw validation message for the same.
| /** | ||
| * Server key. | ||
| */ | ||
| public static final String SERVER_KEY_ID = "AAAAToBmqQQ:APA91bEodkE12CwFl8VHqanUbeJYg1E05TiheVz59CZZYrBnCq3uM40UYhHfdP-JfeTQ0L0zoLqS8orjvW_ze0_VF8DSuyyqkrDibflhtUainsI0lwgVz5u1YP3q3c3erqjlySEuRShS"; |
There was a problem hiding this comment.
Please move to configuration.
| b.notification(notification); | ||
| b.dryRun(false); | ||
| b.contentAvailable(true); | ||
| b.timeToLive(30); |
There was a problem hiding this comment.
See if requirement makes sense to make this parameter configurable.
There was a problem hiding this comment.
No need of configurable parameter for this.
| ) | ||
| COLLATE='utf8_general_ci' | ||
| ENGINE=InnoDB; | ||
|
|
There was a problem hiding this comment.
Remove COLLAGE and Engine hard codings from migration script.
| [group: 'org.apache.activemq', name: 'activemq-broker'], | ||
|
|
||
| //jso simple | ||
| [group: 'com.googlecode.json-simple', name: 'json-simple', version: '1.1'] |
There was a problem hiding this comment.
Please refactor usage of json-simple to GSON library. This will lead to ambiguity during imports and non-standardization of json parsing in the platform.
1)to register client
method - post
url- /device/registration
body
{
"clientId" : 3
"registrationId" : "czxczxczxcv:czxcmzxcnbzx"
}
to get registration by client
method - get
url- /device/registration/client/{clientId}