FINERACT-822 Update and add more checks to be enabled #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From #971 |
|
I expect this will fail to build, as per #971. Just do only the adding of the checks here, not don't upgrade, in this PR (or a new one). Adjust title and commit message. |
percyashu
force-pushed
the
Update_ErrorProne
branch
from
465ab5f
to
4897a30
Compare
percyashu
changed the title
|
@vorburger Will do only for the checks |
vorburger
approved these changes
Jun 2, 2020
|
@vorburger am sure this will fail since the checks I added aren't available for ver 2.3.4 |
|
@vorburger should I update it manually |
xurror
reviewed
Jun 4, 2020
| "ProtectedMembersInFinalClass", | ||
| "StaticAssignmentInConstructor", | ||
| "UnescapedEntity", | ||
| "EmptyCatch", |
There was a problem hiding this comment.
Seems this is not a valid check, maybe a typo or maybe you meant something else and wrote something else. I can merge this once this is resolved.
percyashu
force-pushed
the
Update_ErrorProne
branch
from
4897a30
to
5797481
Compare
percyashu
force-pushed
the
Update_ErrorProne
branch
from
5797481
to
ae5d7a3
Compare
percyashu
changed the title
|
Since this passes, #971 can be closed |
xurror
reviewed
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FINERACT-822