Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] Fix compilation error due to constructor removal of MockSourceReader #89

Merged
merged 1 commit into from
May 17, 2024
Merged

[hotfix] Fix compilation error due to constructor removal of MockSourceReader #89

merged 1 commit into from
May 17, 2024

Conversation

Zakelly
Copy link
Contributor

@Zakelly Zakelly commented May 17, 2024

Due to this commit in main repo apache/flink@4139106 , there is a compilation error. This PR change to use another constructor of MockSourceReader to fix this.

fredia
fredia approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@fredia fredia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM

@Zakelly Zakelly merged commit 6b38e11 into apache:master May 17, 2024
1 check passed
@pnowojski
Copy link
Contributor

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredia fredia fredia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Zakelly @pnowojski @fredia