Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify ownership to comply with ASF trademark policies #1000

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

knaufk
Copy link
Contributor

@knaufk knaufk commented Mar 24, 2022

No description provided.

Copy link

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme also needs changes.

@knaufk
Copy link
Contributor Author

knaufk commented Mar 24, 2022

The readme also needs changes.

Of course. Done.

@wuchong
Copy link
Member

wuchong commented Mar 24, 2022

@knaufk @zentol , could we remove the "Ververica" in the names and titles? As we discussed before, we would like to move this project to flink-extended group which is more neutral. I think "Ververica" in the names would block us to move it.

@leonardBang leonardBang self-requested a review March 24, 2022 10:01
@knaufk
Copy link
Contributor Author

knaufk commented Mar 24, 2022

@wuchong I don't have strong feelings about the "Ververica" in the name, but I don't understand how it blocks us from moving it to flink-extended. In my understanding the ownership of the code and copyright does not change if it is moved to a different repository. The copyright would still belong to Ververica regardless of the location of the repository and the name.

@wuchong
Copy link
Member

wuchong commented Mar 24, 2022

@knaufk I think it's fine to clarify "Ververica" in the copyright. I just don't think it's a good idea to change the tiltes and names.

@wuchong
Copy link
Member

wuchong commented Mar 24, 2022

@knaufk , if the project is renamed to "Ververica CDC ..." project, it is of course not neutral, and against our original intention to move into flink-extended. Last year, contributors from Cloudera would like to contribute this project, but the main concern is this project is not neutral (has Alibaba and Ververica cloud service background).

@knaufk
Copy link
Contributor Author

knaufk commented Mar 24, 2022

Let's leave the discussion of moving the project out of this PR. I have changed the name to "CDC Connectors for Apache Flink". This does not matter in my opinion.

@knaufk knaufk force-pushed the trademark-flink branch 2 times, most recently from c78e3f1 to dccc112 Compare March 24, 2022 10:46
@zentol
Copy link

zentol commented Mar 24, 2022

I don't understand how this would block a move to flink-extended. At that point you need to prune all mentions of ververica anyway; how do 5-6 additional instances block you?

@wuchong
Copy link
Member

wuchong commented Mar 24, 2022

Thanks @knaufk for the updating!

@wuchong
Copy link
Member

wuchong commented Mar 24, 2022

Hi @zentol , my thought is we need to make this project neutral before moving to flink extended. We can rename it again after moving to flink extended, but it would be better to reach consensus at the beginning, and avoid changing titles back and forth. The project might move to flink extended in the next weeks, so I would like we can have an agreement here instead of having another discussion in the near future.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knaufk
Copy link
Contributor Author

knaufk commented Mar 24, 2022

Thanks everyone for the quick reviews. Merging.

@knaufk knaufk merged commit 60d15fb into apache:master Mar 24, 2022
@leonardBang
Copy link
Contributor

Thank you for your contribution @knaufk @zentol, I must state my attitude here. What makes me feel a little uncomfortable is that as an open source community, consensus is a minimum principle, rather than two people who have never contributed to project yet suddenly come up with the PR and then AC directly without informing other community contributors who are active or keep going on the project.

In one word, I don't mind how many instances or the name of the project, all things we can discuss and then start it. What I really mind is the communication way in an open source community.

@knaufk
Copy link
Contributor Author

knaufk commented Mar 24, 2022

I am sorry that this upset you. They way I see it:

  1. This project was not adhering to the ASF Trademark Policy. It is hosted under the veverica github organisation, so I wanted to clean this up myself instead of bringing it up with the Flink PMC and officially reaching out to you (or us) on its behave.

  2. It was approved by two people and I took Jark's approval as a Top-3 contributor to the project as enough to merge.

You can of course open a new PR to change the name back to something else that adheres to the policy.

@leonardBang
Copy link
Contributor

What I said is aimed to the change before jark‘s +1 i.e. your initial commit of this PR,the final change looks good to me too,and I also found a typo and have fixed it. Thanks for your PR again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants