-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify ownership to comply with ASF trademark policies #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme also needs changes.
Of course. Done. |
@knaufk @zentol , could we remove the "Ververica" in the names and titles? As we discussed before, we would like to move this project to flink-extended group which is more neutral. I think "Ververica" in the names would block us to move it. |
@wuchong I don't have strong feelings about the "Ververica" in the name, but I don't understand how it blocks us from moving it to flink-extended. In my understanding the ownership of the code and copyright does not change if it is moved to a different repository. The copyright would still belong to Ververica regardless of the location of the repository and the name. |
@knaufk I think it's fine to clarify "Ververica" in the copyright. I just don't think it's a good idea to change the tiltes and names. |
@knaufk , if the project is renamed to "Ververica CDC ..." project, it is of course not neutral, and against our original intention to move into flink-extended. Last year, contributors from Cloudera would like to contribute this project, but the main concern is this project is not neutral (has Alibaba and Ververica cloud service background). |
Let's leave the discussion of moving the project out of this PR. I have changed the name to "CDC Connectors for Apache Flink". This does not matter in my opinion. |
c78e3f1
to
dccc112
Compare
I don't understand how this would block a move to flink-extended. At that point you need to prune all mentions of ververica anyway; how do 5-6 additional instances block you? |
Thanks @knaufk for the updating! |
Hi @zentol , my thought is we need to make this project neutral before moving to flink extended. We can rename it again after moving to flink extended, but it would be better to reach consensus at the beginning, and avoid changing titles back and forth. The project might move to flink extended in the next weeks, so I would like we can have an agreement here instead of having another discussion in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks everyone for the quick reviews. Merging. |
Thank you for your contribution @knaufk @zentol, I must state my attitude here. What makes me feel a little uncomfortable is that as an open source community, consensus is a minimum principle, rather than two people who have never contributed to project yet suddenly come up with the PR and then AC directly without informing other community contributors who are active or keep going on the project. In one word, I don't mind how many instances or the name of the project, all things we can discuss and then start it. What I really mind is the communication way in an open source community. |
I am sorry that this upset you. They way I see it:
You can of course open a new PR to change the name back to something else that adheres to the policy. |
What I said is aimed to the change before jark‘s +1 i.e. your initial commit of this PR,the final change looks good to me too,and I also found a typo and have fixed it. Thanks for your PR again |
No description provided.