[tidb-cdc] Monitor tidb table lose data, which table has one more regions. #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Jun 23, 2022
| * Copied from https://github.com/tikv/client-java project to fix | ||
| * https://github.com/tikv/client-java/issues/600 for 3.2.0 version. | ||
| * | ||
| * <p>Line 98 : Use `currentCache.size() > scanLimit` instead of `currentCache.size() > limit`. |
There was a problem hiding this comment.
minor: The line number looks wrong?
There was a problem hiding this comment.
minor: The line number looks wrong?
Thanks for your mind, I will fix it(line 98 is according to source code).
GOODBOY008
force-pushed
the
master_tidb
branch
2 times, most recently
from
cc23b61
to
562f711
Compare
leonardBang
approved these changes
Jun 24, 2022
|
Plz feel free to merge, @GOODBOY008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link #1159.