Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data loss in tidb-cdc when switch from snapshot read to change event read #1207

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix data loss in tidb-cdc when switch from snapshot read to change event read #1207

merged 1 commit into from
Oct 28, 2022

Conversation

xieyi888
Copy link
Contributor

@xieyi888 xieyi888 commented May 19, 2022 •
edited

Signed-off-by: Yi Xie xieyi01@rd.netease.com

Link： #1206

fix data loss in tidb-cdc when switch from snapshot read to change ev…
b7f0bee 
…ent read 

Signed-off-by: Yi Xie <xieyi01@rd.netease.com>
@xieyi888 xieyi888 mentioned this pull request May 19, 2022
Closed
@GOODBOY008
Copy link
Member

@xieyi888 When I add unit test in pr #1632 . I had reproduced this sceno in my added unit test.

@GOODBOY008
Copy link
Member

GOODBOY008 commented Oct 28, 2022 •
edited

@xieyi888 It's great catch ,Thanks for your contributions. When run unit test com.ververica.cdc.connectors.tidb.table.TiDBConnectorITCase#testRegionChange with reomove code waitForSinkSize("sink", 1); ,will occur data lost.

@GOODBOY008 GOODBOY008 self-requested a review October 28, 2022 11:40
GOODBOY008
GOODBOY008 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xieyi888 Thanks for your contributions. LGTM ! This scene Unit test will be added in pr #1632 .

@GOODBOY008 GOODBOY008 merged commit a6fa1e6 into apache:master Oct 28, 2022
@xieyi888
Copy link
Contributor Author

xieyi888 commented Oct 31, 2022 •
edited

@xieyi888 It's great catch ,Thanks for your contributions. When run unit test com.ververica.cdc.connectors.tidb.table.TiDBConnectorITCase#testRegionChange with reomove code `waitForSinkSize(

@xieyi888 It's great catch ,Thanks for your contributions. When run unit test com.ververica.cdc.connectors.tidb.table.TiDBConnectorITCase#testRegionChange with reomove code waitForSinkSize("sink", 1); ,will occur data lost.

@GOODBOY008 Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xieyi888 @GOODBOY008