Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongodb] Expose batch.size config option for table source. #1387

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

Jiabao-Sun
Copy link
Contributor

batch.size configures the MongoDB cursor and specifies the maximum number of change events to return in each batch of the response from the MongoDB cluster. The default is 0 meaning it uses the servers default.

Expose this config option for table source so that users can customize the configuration for change stream cursor batches.

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. LGTM.

docs/content/connectors/mongodb-cdc.md Outdated Show resolved Hide resolved
@Jiabao-Sun
Copy link
Contributor Author

Hi @GOODBOY008, please help review it when you are available.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun Thanks for your great works.I have left minor comments.

"Change stream cursor batch size. "
+ "Specifies the maximum number of change events to return in each batch "
+ "of the response from the MongoDB cluster."
+ "Defaults to 0 meaning it uses the servers default value.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

servers -> server's .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docs/content/connectors/mongodb-cdc.md Outdated Show resolved Hide resolved
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GOODBOY008 GOODBOY008 merged commit 02eca30 into apache:master Jul 22, 2022
@Jiabao-Sun Jiabao-Sun deleted the expose-batch-size-config branch December 27, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants