[mysql] Use local timezone as the default server timezone #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spotless failed. It seems you should run |
syhily
reviewed
Jul 26, 2022
...ysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java
Outdated
Show resolved
Hide resolved
syhily
reviewed
Jul 26, 2022
...l-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/config/MySqlSourceOptions.java
Outdated
Show resolved
Hide resolved
|
OracleE2eITCase.testOracleCDC failed, but it seems unrelated to the changes made. |
@kylemeow Thanks for the contribution, I've fixed the test, could you rebase master and try again? |
kylemeow
force-pushed
the
kyle-timezone-fix
branch
from
76f9fc5
to
8850631
Compare
leonardBang
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Thanks @kylemeow for the contribution, I left some comments
...l-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/config/MySqlSourceOptions.java
Show resolved
Hide resolved
kylemeow
force-pushed
the
kyle-timezone-fix
branch
from
b9476d5
to
828c018
Compare
leonardBang
reviewed
Aug 12, 2022
There was a problem hiding this comment.
Thanks @kylemeow for the contribution, I left a few comments
flink-connector-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/MySqlTestUtils.java
Outdated
Show resolved
Hide resolved
flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/MySqlValidator.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Thanks @kylemeow for the nice work, so happy to discuss with you, LGTM.
fuyun2024
pushed a commit
to fuyun2024/flink-cdc-connectors
that referenced
this pull request
Sep 22, 2022
… option (apache#1407) This closes apache#1406.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the issue mentioned in #1406, Flink CDC Connectors might treat Timestamp fields with different behaviors during snapshot and streaming phases.
Here I propose changing the default value of
server-time-zoneto local timezone so that most users would not need to manually set timezone to get the correct results.