Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][test] fix the error in MySqlSourceITCase when adding the savepoint path #1446

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[hotfix][test] fix the error in MySqlSourceITCase when adding the savepoint path #1446

merged 1 commit into from
Aug 8, 2022

Conversation

ruanhang1993
Copy link
Contributor

StreamExecutionEnvironment#getConfiguration now returns an unmodifiable configuration, which will cause test failing.

@whhe whhe mentioned this pull request Aug 4, 2022
Closed
@ruanhang1993 ruanhang1993 changed the title [hotfix] fix the error when adding the savepoint path [hotfix][test] fix the error in MySqlSourceITCase when adding the savepoint path Aug 4, 2022
leonardBang
leonardBang approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the contribution, LGTM

@leonardBang leonardBang merged commit 6a56985 into apache:master Aug 8, 2022
@ruanhang1993 ruanhang1993 deleted the testFix branch August 11, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruanhang1993 @leonardBang