[mysql] support to checkpoint in chunk level at the snapshot phase #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Aug 30, 2022
...sql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/assigners/ChunkSplitter.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
.../com/ververica/cdc/connectors/mysql/source/assigners/state/PendingSplitsStateSerializer.java
Outdated
Show resolved
Hide resolved
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/split/MySqlSplitSerializer.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
ruanhang1993
force-pushed
the
github-chunk
branch
3 times, most recently
from
6caa905
to
79ff06f
Compare
ruanhang1993
force-pushed
the
github-chunk
branch
from
79ff06f
to
e6fb4e2
Compare
|
@ruanhang1993 Could you help rebase this PR as there're conflicts now？ |
ruanhang1993
force-pushed
the
github-chunk
branch
from
e6fb4e2
to
5a27946
Compare
Rebased. @leonardBang . Thanks. |
leonardBang
reviewed
Oct 20, 2022
.../main/java/com/ververica/cdc/connectors/mysql/source/assigners/state/ChunkSplitterState.java
Outdated
Show resolved
Hide resolved
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
...sql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/assigners/ChunkSplitter.java
Outdated
Show resolved
Hide resolved
...sql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/assigners/ChunkSplitter.java
Outdated
Show resolved
Hide resolved
ruanhang1993
force-pushed
the
github-chunk
branch
from
5a27946
to
b18f771
Compare
ruanhang1993
force-pushed
the
github-chunk
branch
from
a448a5e
to
ca57d63
Compare
leonardBang
reviewed
Oct 26, 2022
...ain/java/com/ververica/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigner.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks @ruanhang1993 for the contribution, LGTM once fix the minor comment
ruanhang1993
force-pushed
the
github-chunk
branch
from
e964d93
to
4ca0977
Compare
ruanhang1993
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports to checkpoint in chunk level at the snapshot phase.