[mysql] Let the records of snapshot split don't cross checkpoints #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ruanhang1993 Would you like to help review this PR？ |
There was a problem hiding this comment.
@leonardBang Thanks for the contribution. I left some comments.
...-cdc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java
Show resolved
Hide resolved
...r-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/source/split/SourceRecords.java
Show resolved
Hide resolved
...tor-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/source/MySqlSourceITCase.java
Outdated
Show resolved
Hide resolved
...dc/src/test/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReaderTest.java
Show resolved
Hide resolved
...dc/src/test/java/com/ververica/cdc/connectors/mysql/source/reader/MySqlSourceReaderTest.java
Outdated
Show resolved
Hide resolved
leonardBang
changed the title
address comments
leonardBang
force-pushed
the
make_chunk_between_cps
branch
from
db371f4
to
9fcad5b
Compare
...dc/src/main/java/com/ververica/cdc/connectors/mysql/debezium/reader/SnapshotSplitReader.java
Outdated
Show resolved
Hide resolved
ruanhang1993
approved these changes
Aug 25, 2022
fuyun2024
pushed a commit
to fuyun2024/flink-cdc-connectors
that referenced
this pull request
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output records of a snapshot split should not cross checkpoints, this may lead to data duplication when failover happen, because partial snapshot records of one split may sent in last checkpoint, but this snapshot split may be re-read all snapshot records after failover, this behavior bring potential data duplication issue.