[mysql] fix error when alter sqls contains default string value and collate. #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Thanks @ruanhang1993 for the contribution, the PR generally LGTM. I only left one minor comment about the test/
...r-mysql-cdc/src/test/java/com/ververica/cdc/connectors/mysql/table/MySqlConnectorITCase.java
Outdated
Show resolved
Hide resolved
ruanhang1993
force-pushed
the
issue1506
branch
from
95211bd
to
18f3445
Compare
leonardBang
approved these changes
Sep 21, 2022
fuyun2024
pushed a commit
to fuyun2024/flink-cdc-connectors
that referenced
this pull request
Sep 22, 2022
…ing value and collate. (apache#1544) This closes apache#1506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed #1506.