Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]add document for the usage of regex to match multi-tables #1564

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

LXin96
Copy link
Contributor

@LXin96 LXin96 commented Sep 19, 2022

add document for the usage of regex to match multi-tables

@LXin96 LXin96 changed the title add document for the usage of regex to match multi-tables [doc]add document for the usage of regex to match multi-tables Sep 20, 2022
@LXin96
Copy link
Contributor Author

LXin96 commented Sep 20, 2022

@leonardBang Hello. I tried to add some examples to describe the usage of regex to match multi-tables . So I'm sincerely you could review it and give some advices

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LXin96 Thanks for the nice work, Could you also add examples for English docs?

@LXin96
Copy link
Contributor Author

LXin96 commented Sep 20, 2022

@leonardBang OK, I have added some examples for English docs, maybe you could have a look.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LXin96 for the contribution, LGTM

@leonardBang leonardBang merged commit 569c6a5 into apache:master Sep 21, 2022
@LXin96
Copy link
Contributor Author

LXin96 commented Sep 21, 2022

@leonardBang I'm very glad to do that!

@LXin96 LXin96 deleted the regex-document branch September 22, 2022 05:07
fuyun2024 pushed a commit to fuyun2024/flink-cdc-connectors that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants