Support Db2 cdc connector (cp from #450) #1626
Conversation
ruanhang1993
force-pushed
the
db2
branch
4 times, most recently
from
5a7eb09
to
3c205fa
Compare
leonardBang
requested review from
GOODBOY008
and removed request for
leonardBang
|
Thanks @ruanhang1993 for picking up the hanging task, @GOODBOY008 Would you like to take a look this PR？ |
There was a problem hiding this comment.
@ruanhang1993 Thanks for your contributions. Should add e2e test and metadata columns support.
flink-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/Db2Source.java
Outdated
Show resolved
Hide resolved
flink-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/Db2Source.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| public void testConsumingAllEvents() |
There was a problem hiding this comment.
Should add timezone unit test.
There was a problem hiding this comment.
Actually the time zone information for the timestamp types will not be contained in the debezium db2 connector. IMO this time zone setting may be useless.
...k-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/table/StartupOptions.java
Outdated
Show resolved
Hide resolved
flink-connector-db2-cdc/src/test/java/com/ververica/cdc/connectors/db2/Db2TestBase.java
Outdated
Show resolved
Hide resolved
flink-cdc-e2e-tests/src/test/java/com/ververica/cdc/connectors/tests/Db2E2eITCase.java
Outdated
Show resolved
Hide resolved
...nector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/table/Db2ReadableMetaData.java
Show resolved
Hide resolved
flink-connector-db2-cdc/src/test/java/com/ververica/cdc/connectors/db2/Db2TestBase.java
Outdated
Show resolved
Hide resolved
|
@ruanhang1993 DB2 unit test is not runned , you can modify file in directory |
There was a problem hiding this comment.
Thanks @ruanhang1993 and @GOODBOY008 for the great work. LGTM, I've checked the tutorial it works well.
|
Implemented in 3592dcc |
Support Db2 cdc connector , cherry pick from #450 .