[hotfix][docs] Correct reference link for DB2 docs #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiabao-Sun
force-pushed
the
fix-db2-docs
branch
from
2294146
to
054a56f
Compare
gtk96
reviewed
Nov 1, 2022
|
Thanks @Jiabao-Sun for this contribution. I left a litter comments.
On line 163 of the file and "latest-offset". Please see Startup Reading Positionsection A space is required here besides, LGTM |
Jiabao-Sun
force-pushed
the
fix-db2-docs
branch
from
f97ace2
to
9519246
Compare
|
Thanks @RookieGao for the detailed review. |
ruanhang1993
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Thanks for your work, @Jiabao-Sun. Just a little suggestion.
docs/content/connectors/db2-cdc.md
Outdated
| @@ -246,8 +246,7 @@ Data Type Mapping | |||
| <table class="colwidths-auto docutils"> | |||
| <thead> | |||
| <tr> | |||
| <th class="text-left" style="width:30%;">Db2 type<a href="https://dev.mysql.com/doc/man/8.0/en/data-types. | |||
| html"></a></th> | |||
| <th class="text-left" style="width:30%;"><a href="https://www.ibm.com/docs/en/db2-for-zos/12?topic=elements-data-types">Db2 type</a></th> | |||
There was a problem hiding this comment.
I think this is better to link to https://www.ibm.com/docs/en/db2/11.5?topic=elements-data-types.
There was a problem hiding this comment.
Thanks @ruanhang1993 for this suggestion.
Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct reference link for DB2 docs