Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug][tidb-connector]checkpoint is not updated long after a task has been running #1686

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

wangxiaojing
Copy link
Contributor

@wangxiaojing wangxiaojing commented Nov 1, 2022

Describe the bug(Please use English)

Environment :

Flink version : 1.14
Flink CDC version: 2.3
Database and version: 5.1
To Reproduce
Steps to reproduce the behavior:

The error :
``2022-10-27 12:48:34,981 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953707961122840, regionId: 1721083
2022-10-27 12:48:35,469 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953708092194817, regionId: 10236245
2022-10-27 12:48:35,469 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953708092194817, regionId: 10237829
2022-10-27 12:48:35,469 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953708092194817, regionId: 8419115
2022-10-27 12:48:35,477 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953708092194820, regionId: 7318373
2022-10-27 12:48:35,477 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953708092194820, regionId: 11085331
2022-10-27 12:48:35,631 INFO com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction [] - snapshotState checkpoint: 9 at resolvedTs: 4369527563128668272022-10-27 12:58:35,594 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953865404809241, regionId: 8684959 2022-10-27 12:58:35,594 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953865404809241, regionId: 8309437 2022-10-27 12:58:35,594 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953865404809241, regionId: 1721083 2022-10-27 12:58:35,594 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436953865404809241, regionId: 11090547 2022-10-27 12:58:35,635 INFO com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction [] - snapshotState checkpoint: 10 at resolvedTs: 436952756312866827

2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 8424191 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 8343109 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 3287795 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 8221803 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 11120919 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 10296761 2022-10-2 7 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 8309437 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 8684959 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 11090547 2022-10-27 13:08:35,197 INFO org.tikv.cdc.CDCClient [] - handle resolvedTs: 436954022586351623, regionId: 1721083 2022-10-27 13:08:35,632 INFO com.ververica.cdc.connectors.tidb.TiKVRichParallelSourceFunction [] - snapshotState checkpoint: 11 at resolvedTs: 436952756312866827

Additional Description
update the resolvedTs from the max ResolvedTs

@wangxiaojing wangxiaojing changed the title read resolvedTs from Max ResolvedTs [bug][tidb-connector]checkpoint is not updated long after a task has been running #1685 Nov 1, 2022
@wangxiaojing wangxiaojing changed the title [bug][tidb-connector]checkpoint is not updated long after a task has been running #1685 [bug][tidb-connector]checkpoint is not updated long after a task has been running Nov 1, 2022
@GOODBOY008
Copy link
Member

@wangxiaojing Thanks for your contribution ,can you add unit test to make sure it's worked.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangxiaojing LGTM , Thanks for your contribution.

@GOODBOY008
Copy link
Member

This pr will hang until master CDCclient class add method getMaxResolvedTs back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants