Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix doc #1751

Merged
merged 2 commits into from
Nov 18, 2022
Merged

fix doc #1751

merged 2 commits into from
Nov 18, 2022

Conversation

xixingya
Copy link
Contributor

@gtk96
Copy link
Contributor

gtk96 commented Nov 16, 2022

Thanks @xixingya the contribution, I left some comments.

mysql-cdc.md Line 256

image

It seems that it also needs to be changed to long

@xixingya
Copy link
Contributor Author

Thanks @xixingya the contribution, I left some comments.

mysql-cdc.md Line 256

image

It seems that it also needs to be changed to long

Thanks, now I fixed it

gtk96
gtk96 approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@gtk96 gtk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@gtk96
Copy link
Contributor

gtk96 commented Nov 18, 2022

@Jiabao-Sun PTAL

Jiabao-Sun
Jiabao-Sun approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xixingya @RookieGao for the great work.
LGTM.

@Jiabao-Sun Jiabao-Sun merged commit 7a2312c into apache:master Nov 18, 2022
@Jiabao-Sun Jiabao-Sun mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiabao-Sun Jiabao-Sun Jiabao-Sun approved these changes

@gtk96 gtk96 gtk96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xixingya @gtk96 @Jiabao-Sun