Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC ] Update data type mapping #1802

Merged
merged 5 commits into from
Dec 27, 2022
Merged

[DOC ] Update data type mapping #1802

merged 5 commits into from
Dec 27, 2022

Conversation

wangxiaojing
Copy link
Contributor

SQL Server 's type tinyint with values from 0 to 255.
Flink 's type tinyint with values from -128 to 127.

Caused by: java.lang.NumberFormatException: Value out of range. Value:"255" Radix:10
	at java.base/java.lang.Byte.parseByte(Unknown Source)
	at java.base/java.lang.Byte.parseByte(Unknown Source)

2.float Mapping to double

@GOODBOY008
Copy link
Member

GOODBOY008 commented Dec 6, 2022 •
edited

@wangxiaojing Thanks for your contributions! Can you revoke unchanged lines? And you can also correct type mapping in com.ververica.cdc.connectors.sqlserver.table.SqlServerConnectorITCase#testAllTypes.

@GOODBOY008 GOODBOY008 self-requested a review December 6, 2022 12:10
GOODBOY008
GOODBOY008 reviewed Dec 6, 2022
View reviewed changes
docs/content/connectors/sqlserver-cdc.md Outdated
@@ -1,11 +1,13 @@
# SQLServer CDC Connector

The SQLServer CDC connector allows for reading snapshot data and incremental data from SQLServer database. This document describes how to setup the SQLServer CDC connector to run SQL queries against SQLServer databases.
The SQLServer CDC connector allows for reading snapshot data and incremental data from SQLServer database. This document
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not format files.

docs/content/connectors/sqlserver-cdc.md
@@ -369,7 +405,7 @@ Data Type Mapping
</tr>
<tr>
<td>tinyint</td>
<td>TINYINT</td>
<td>SMALLINT</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix corresponding all types test.

GOODBOY008
GOODBOY008 approved these changes Dec 27, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit 00fe5ad into apache:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wangxiaojing @GOODBOY008