Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[postgres] Change config option slot.name to be required #1996

Merged
merged 1 commit into from
Apr 20, 2023
Merged

[postgres] Change config option slot.name to be required #1996

merged 1 commit into from
Apr 20, 2023

Conversation

ruanhang1993
Copy link
Contributor

Change config option slot.name to be required, see #1386.

@ruanhang1993
Copy link
Contributor Author

@GOODBOY008 Do you have time to help to review this PR ?

GOODBOY008
GOODBOY008 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit 727a070 into apache:master Apr 20, 2023
@GOODBOY008 GOODBOY008 mentioned this pull request Apr 20, 2023
Closed
@ruanhang1993 ruanhang1993 deleted the pr1386 branch October 23, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

@loserwang1024 loserwang1024 loserwang1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ruanhang1993 @GOODBOY008 @loserwang1024