Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debezium] Bump debezium version to 1.9.7.Final #2156

Merged
merged 2 commits into from
Jun 19, 2023
Merged

[debezium] Bump debezium version to 1.9.7.Final #2156

merged 2 commits into from
Jun 19, 2023

Conversation

tigrulya-exe
Copy link
Contributor

@tigrulya-exe tigrulya-exe commented May 26, 2023 •
edited
Loading

This PR upgrades Debezium version to 1.9.7.Final and uses @GOODBOY008 commit from #1236 as basis.

@tigrulya-exe tigrulya-exe mentioned this pull request May 26, 2023
Closed
GOODBOY008
GOODBOY008 reviewed May 27, 2023
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrulya-exe Thanks for your great contributions, fix e2e failure, I just left some comments.

...c/src/main/java/com/ververica/cdc/connectors/mongodb/source/config/MongoDBSourceOptions.java Outdated Show resolved Hide resolved
...-oracle-cdc/src/test/java/com/ververica/cdc/connectors/oracle/source/OracleSourceITCase.java Show resolved Hide resolved
@tigrulya-exe tigrulya-exe force-pushed the bump-debezium-1.9.7 branch 3 times, most recently from 8684c7f to 6ed0ce7 Compare May 30, 2023 10:48
@GOODBOY008
Copy link
Member

GOODBOY008 commented Jun 2, 2023 •
edited
Loading

@tigrulya-exe hi, Can you rebase to master branch and migrate sqlserver to dbz 1.9.7.

@tigrulya-exe tigrulya-exe reopened this Jun 7, 2023
@tigrulya-exe
Copy link
Contributor Author

@GOODBOY008 Hi, I rebased to master and migrated new SqlServer incremental source to the debezium 1.9.7, please take a look. Btw, I have no idea why Github decided to automatically close PR, I reopened it.

@tigrulya-exe tigrulya-exe force-pushed the bump-debezium-1.9.7 branch 3 times, most recently from 3cd65c2 to 892af3f Compare June 8, 2023 10:40
@ruanhang1993
Copy link
Contributor

Hi, @tigrulya-exe . Thanks a lot for the contribution.

#1823 will use Incremental Snapshot Framework for Postgres CDC Connector. We will try to merge it as soon as possible.
Could you help to migrate it to dbz 1.9.7 again after merging that PR?

@tigrulya-exe
Copy link
Contributor Author

@ruanhang1993 Hello! Sure, I'll try to help.

@ruanhang1993
Copy link
Contributor

ruanhang1993 commented Jun 16, 2023 •
edited
Loading

@ruanhang1993 Hello! Sure, I'll try to help.

Hi, @tigrulya-exe . Thanks a lot for your help.
PG CDC PR has already been merged. There are some failed test for pg cdc. We will resolve them in another PR.
Now you could continue developing this PR. Thanks~

ps: Oracle cdc bug fix #2215 also introduces a new debezium class.

@tigrulya-exe
Copy link
Contributor Author

@ruanhang1993 Hi, I've rebased the branch on master and adapted PostgreSQL incremental source to the new version of dbz. However, there are several failed tests, so could you please provide a list of not yet fixed tests in master? It will help me understand which tests are falling only due to my changes.

@GOODBOY008
Copy link
Member

@tigrulya-exe Thanks for your great contributions. @ruanhang1993 I think pg test fail should not be fixed in this pr.

ruanhang1993
ruanhang1993 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tigrulya-exe Thanks a lot for your great work. We will resolve PG cdc tests in another PR.

@ruanhang1993 ruanhang1993 merged commit 2b01734 into apache:master Jun 19, 2023
11 of 14 checks passed
This was referenced Jun 19, 2023
Closed
Closed
Closed
@e-mhui e-mhui mentioned this pull request Jun 28, 2023
Closed
@liugddx liugddx mentioned this pull request Aug 2, 2023
Closed
@loserwang1024 loserwang1024 mentioned this pull request Dec 7, 2023
Merged
@dailai dailai mentioned this pull request Apr 15, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

@ruanhang1993 ruanhang1993 ruanhang1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tigrulya-exe @GOODBOY008 @ruanhang1993