Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oceanbase] use real charset to convert change record #2159

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

whhe
Copy link
Member

@whhe whhe commented May 29, 2023

fix #2114

@whhe whhe changed the title fix: use real charset to convert change record [oceanbase] use real charset to convert change record May 29, 2023
Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution, @whhe . Have these changes been covered by the existed tests?

@whhe
Copy link
Member Author

whhe commented May 30, 2023

Thanks for contribution, @whhe . Have these changes been covered by the existed tests?

Yes.

Copy link
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanhang1993 ruanhang1993 merged commit 23c20cc into apache:master Jun 2, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ob-oracle用flinkcdc抽取nvarchar字段乱码
2 participants